Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test works when run independently, but hangs when run in a collection. #407

Closed
SiJiL82 opened this issue Nov 30, 2021 · 15 comments
Closed
Labels
bug Something isn't working Priority Implement this asap

Comments

@SiJiL82
Copy link

SiJiL82 commented Nov 30, 2021

I have a very basic request for an API tutorial, it just passes a JSON body to the API and gets a JSON object back as a response:
image
I've added this to a collection, and if I run it independently by clicking it in the collection so it opens and click Send, it runs fine - returns instantly.
If I click "Run All" on the collection however, it hangs on the request- the StatusCode column just spins and never comes back.
The request has run - I can manually call the Sign In request in another tab and that then responds correctly, but the Thunder Client UI never comes back from the request:
image
It seems to be doing it for any POST request, the GET I've done worked fine.

Is there something I need to do to the collection config or the requests themselves that I need to do to get it working?

@rangav
Copy link
Collaborator

rangav commented Nov 30, 2021

Hi @SiJiL82 thanks for reporting the issue.

Try restarting vscode and run collection.

@SiJiL82
Copy link
Author

SiJiL82 commented Nov 30, 2021

Hi @rangav - still getting the same thing.
I am running vscode in WSL (Ubuntu) in Windows if that makes any difference.

@rangav
Copy link
Collaborator

rangav commented Nov 30, 2021

Oh ok, can you try locally first without WSL?

It could be WSL issue

@SiJiL82
Copy link
Author

SiJiL82 commented Nov 30, 2021

Just tried in a local VSCode (new copy of the code, so not running from the repo in the WSL file structure) and get the same results.

@jwmickey
Copy link

jwmickey commented Jan 6, 2022

I have observed this as well. A workaround is to close the run-all tab and re-open it.

@rangav
Copy link
Collaborator

rangav commented Jan 7, 2022

Hi guys, can anyone share sample collection that can reproduce the error, for my testing?

You can remove any sensitive data

@rangav rangav added bug Something isn't working Priority Implement this asap labels Jan 15, 2022
@rangav
Copy link
Collaborator

rangav commented Jan 20, 2022

Hi guys, do you still have this issue, I have released a new update v1.10.0, can you confirm please?

@SiJiL82
Copy link
Author

SiJiL82 commented Jan 21, 2022

I'll try and find the API and tests I was using, it was part of a course I was doing before xmas!

@rangav
Copy link
Collaborator

rangav commented Jan 26, 2022

This bug is now fixed in v1.11.0
https://github.com/rangav/thunder-client-support/releases/tag/v1.11.0

please let me know if any feedback

@rangav rangav closed this as completed Jan 26, 2022
@jwmickey
Copy link

Apologies for the delay in feedback - this does appear to be working from my observations so far.

One thing I did notice is that for one request I have a test that expects the response code to be 400, but is now failing because according to TC it is 404. The actual response is indeed 400.

@rangav
Copy link
Collaborator

rangav commented Jan 27, 2022

@jwmickey thanks for confirming

can you try re-run 1 or 2 times, sometimes it could be network issues

@jwmickey
Copy link

jwmickey commented Jan 27, 2022 via email

@rangav
Copy link
Collaborator

rangav commented Jan 27, 2022

@jwmickey thanks for clarification

when you run that request independently are you getting 400 or 404?

@jwmickey
Copy link

I apologize @rangav, it is not 404. The first run it shows "Error" for StatusCode. Then I ran it independently and it showed 400 and the test passed. Then run in collection worked as expected.

First run:
first

Second run:
second

@rangav
Copy link
Collaborator

rangav commented Jan 28, 2022

No problem @jwmickey good that it’s working now.

whenever there is error in run collection, mouse hover on Error text, it will show error details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority Implement this asap
Projects
None yet
Development

No branches or pull requests

3 participants