Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect your dependencies to prevent potentials conflicts with other plugins #279

Open
CrochetFeve0251 opened this issue May 16, 2024 · 0 comments

Comments

@CrochetFeve0251
Copy link

Hey,
Now you are also group.one folks so why not helping each others?

I looked quickly at your code base and I saw two points that might interest you to improve as you are also a plugin used by millions of websites.

Is your feature request related to a problem? Please describe.
I see in your repository you are using Composer and that's a great thing as it enable you to use modern PHP inside your plugin but with great powers comes great responsibilities.

In WordPress env, we are like in a flat and something loaded on the main namespace is more room for conflict and by default composer loads libraries into the main namespace leading to a conflict when another plugin uses the same dependency as you but on a different version.

Describe the solution you'd like
To prevent that it is possible to use coenjacobs/mozart or brianhenryie/strauss to protect your dependencies.

Theses libraries will add a custom namespace before your dependencies preventing any conflicts with other plugins using the same dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant