Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JEI transfer on grids #1395

Closed
raoulvdberge opened this issue Aug 1, 2017 · 8 comments
Closed

Fix JEI transfer on grids #1395

raoulvdberge opened this issue Aug 1, 2017 · 8 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@raoulvdberge
Copy link
Collaborator

Machine recipes also work on regular grids...

@raoulvdberge raoulvdberge changed the title Fixed JEI transfer on grids Fix JEI transfer on grids Aug 1, 2017
@way2muchnoise
Copy link
Contributor

slow clap

@raoulvdberge
Copy link
Collaborator Author

Since I removed Processing pattern encoder and merged it with the pattern grid we can't have a specialized transfer handler anymore since "nice" JEI API design binds it to a container class >.>

@way2muchnoise
Copy link
Contributor

Might be something @mezz can help with

@raoulvdberge raoulvdberge added the bug Something isn't working label Aug 3, 2017
@raoulvdberge
Copy link
Collaborator Author

Wontfix. Since we can't detect machine recipes at the transfer level.

@raoulvdberge raoulvdberge added the wontfix This will not be worked on label Aug 3, 2017
@way2muchnoise
Copy link
Contributor

Well anything that doesn't have the category "crafting" is a "machine" recipe.

@raoulvdberge raoulvdberge reopened this Aug 3, 2017
@raoulvdberge raoulvdberge removed the wontfix This will not be worked on label Aug 3, 2017
@raoulvdberge
Copy link
Collaborator Author

@way2muchnoise How do I get the category from the transfer handler? We only get IRecipeLayout which AFAIK doesn't have any methods to check if it's a regular recipe.

@Darkere
Copy link
Collaborator

Darkere commented Aug 15, 2017

Honestly, don't fix this. I thought it was a feature. Getting all required items for a non crafting recipe proved useful quite a few times. Especially if I need like 5 different items. Otherwise I have to remember and look up every item individually.

@raoulvdberge
Copy link
Collaborator Author

Yeah, I see how it could be handy.

@raoulvdberge raoulvdberge added the wontfix This will not be worked on label Aug 16, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants