Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Spout 3.0 ? #142

Closed
johanrosenson opened this issue Dec 23, 2019 · 3 comments
Closed

Upgrade to Spout 3.0 ? #142

johanrosenson opened this issue Dec 23, 2019 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@johanrosenson
Copy link
Contributor

Spout version 3 is available, would it be possible to upgrade to use that version instead of 2.7?

According to the upgrade guide there are some breaking changes between 2.7 and 3.0
https://github.com/box/spout/blob/master/UPGRADE-3.0.md

I have not done any tests myself yet, but creating an issue if someone wants to try (or if i get time soon to do some tests).
@rap2hpoutre rap2hpoutre added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request and removed good first issue Good for newcomers labels Mar 5, 2020
@oriceon
Copy link

oriceon commented Jul 25, 2020

Hi there, any news regarding that?

@rap2hpoutre
Copy link
Owner

rap2hpoutre commented Sep 17, 2020 •
edited

It should be considered. Still, I read the upgrade documentation and it seems it's not that simple. We would have to adapt some code, adapt tests, and check the benchmark again (since creating a new row for each read line could consume some more memory and time). However, I would be super happy to review a PR on this topic 😄

@rap2hpoutre rap2hpoutre mentioned this issue Feb 22, 2021
Closed
@rap2hpoutre
Copy link
Owner

rap2hpoutre commented May 1, 2021 •
edited

I just updated fast-excel to use Spout v3: composer require rap2hpoutre/fast-excel:^3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@oriceon @rap2hpoutre @johanrosenson