null handling

[janokary]

If in the first line of the outputted excel there is a null value then all columns are mixed up in the following lines.

Any suggestions?

[rap2hpoutre]

Thank you for your contribution. Could you please provide a (small) example of an Excel that produce the bug? I could add it to the unit tests and fix the bug!

[janokary]

When there are nulls values the null cells are skipped (or better missing) end the rest of the line is shifted to the left.

file-3.xlsx

[rap2hpoutre]

I can not reproduce the problem. I tried this but it's OK (no bugs):

$original_collection = collect([
    ['col1' => 'val1', 'col2' => 'val2'],
    ['col1' => null, 'col2' => 'val2'] // <= the "null" value is here. 
]);

$filename = __DIR__ . '/test2.xlsx';

(new FastExcel($original_collection))->export($filename);
$res = (new FastExcel())->import($filename);

$this->assertEquals($original_collection, $res); // <= My unit test is green, success

unlink($filename);

Could you paste a relevant part of your collection (thank you for your time!)?

[janokary]

this is my example (full of nulls):
code.txt

[rap2hpoutre]

Thank you! Fixed via b8f3fec, available in v0.4.0 (just update your version with composer and it should work!). Let me know if something went wrong!

[rap2hpoutre]

Also, I added a unit test with your case, thanks to you:

fast-excel/tests/IssuesTest.php

Lines 96 to 112 in dd31e83

	public function testIssue32()
	{
	$original_collection = collect([
	[
	'duration_in_months' => 1,
	'expires_at' => '2018-08-06',
	],
	[
	'duration_in_months' => null,
	'expires_at' => '1970-01-01',
	],
	]);
	(new FastExcel(clone $original_collection))->export(__DIR__.'/test2.xlsx');
	$res = (new FastExcel())->import(__DIR__.'/test2.xlsx');
	$this->assertEquals($original_collection[1], $res[1]);
	unlink(__DIR__.'/test2.xlsx');
	}

[janokary]

It is fixed. You are super cool.

[rap2hpoutre]

Thank you!

[mrwcjoughin]

@rap2hpoutre I am using the latest nuget package and it seems this issue is happening again?
if a cell is blank then the cell is not being included in the cells enumeration for that row at all?
how has this regressed if there is a test for it?

[cedrictwillie]

I believe I am experiencing the same issue on version v5.3.0..