Skip to content
This repository has been archived by the owner on Mar 29, 2024. It is now read-only.

Require Example for Better Understanding. #9

Closed
WeeHong opened this issue Jan 16, 2018 · 6 comments
Closed

Require Example for Better Understanding. #9

WeeHong opened this issue Jan 16, 2018 · 6 comments

Comments

@WeeHong
Copy link

WeeHong commented Jan 16, 2018

Hello @rap2hpoutre

I would suggest providing some examples other than just showing the code,

StripeConnect::transaction($token)
    ->amount(1000, 'usd')
    ->from($customer)
    ->to($vendor)
    ->create(); 
  1. What is the $token about? Where should I retrieve the token? From STRIPE_KEY or STRIPE_SECRET?
  2. The $customer and $vendor are emails or texts? As you mentioned, $customer and $vendor must be User instances. Assuming I do not have the knowledge of OOP, what is User instance? Is that referring to an Object or an Array or anything?

Thank you for developing this package. :D

@rap2hpoutre
Copy link
Owner

Thank you for contributing!

You are right, some more explanation would help users to understand this package. Do you think you could send a PR? (As you want, I can do it if you prefer)

@WeeHong
Copy link
Author

WeeHong commented Jan 16, 2018

Hi @rap2hpoutre

I am happy to improve on the explanation but I would like to familiarize myself with the package.

@rap2hpoutre
Copy link
Owner

Ok, let's start! I just added some words about the $token var. 29feeca

@WeeHong
Copy link
Author

WeeHong commented Jan 17, 2018

@rap2hpoutre

I left my comment on the link which you provided.
Not sure if I am allowed to modify the README.md directly.

@rap2hpoutre
Copy link
Owner

rap2hpoutre commented Apr 19, 2018

Not sure if I am allowed to modify the README.md directly.

You are allowed! Jut open a pull request

@rap2hpoutre
Copy link
Owner

This package is deprecated, looking for a competitor. See this reddit post.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants