Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporting Extra GG Corrected Values in rm_anova #307

Closed
Esmerald1no opened this issue Oct 27, 2022 · 1 comment
Closed

Reporting Extra GG Corrected Values in rm_anova #307

Esmerald1no opened this issue Oct 27, 2022 · 1 comment
Labels
feature request 🚧 New feature or request

Comments

@Esmerald1no
Copy link

I believe it would be a great addition to the package!
Generally, when reporting GG corrected p-values, the corrected F value and ddofs are also reported.
It is also a relatively easy addition.
(...)
if correction:
(...)
corr_fval = f(corr_ddof1, corr_ddof2).ppf(1-p_corr)

then during the formation of dataframe:
if not detailed:
(....)
aov["F"] = corr_fval
aov["DF"] = [corr_ddof1,corr_ddof2]
else:
(...)
aov["DF"] = [corr_ddof1,corr_ddof2]
aov["F"] = [corr_fval,np.nan]
(...)

@raphaelvallat raphaelvallat added the feature request 🚧 New feature or request label Oct 27, 2022
@raphaelvallat
Copy link
Owner

Thanks @Esmerald1no for opening the issue.

I don't think we should replace the F-value and DF, because we are still reporting the uncorrected p-value. If anything, we should add the F_corr and DF_corr to the dataframe, but I am worried that it will overburden the output, which is already quite extensive.

Alternatively, we could switch to a class implementation class RepeatedMeasuresANOVA where there would be methods to report the corrected and non-corrected values. I've been wanting to rewrite some of these functions using https://github.com/matthewwardrop/formulaic as the backend, but this will take a significant amount of time which I don't have now.

Curious to hear your (and others) thoughts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request 🚧 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants