Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuzzy Finder is Slow #132

Closed
hedonistrh opened this issue Jul 10, 2023 · 6 comments
Closed

Fuzzy Finder is Slow #132

hedonistrh opened this issue Jul 10, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@hedonistrh
Copy link

Hey,

I am using https://github.com/junegunn/fzf as fuzzy finder via zsh shell (so [ -f ~/.fzf.zsh ] && source ~/.fzf.zsh is added in .zshrc). However, it takes 2-3 seconds after I press cmd + R to see latest commands. That is not the case for kitty or iterm2 as they instantly show that.

I am using osx and Rio 0.0.8. How I can share useful logs or are you able to re-produce that issue on your end?

@raphamorim raphamorim added the bug Something isn't working label Jul 11, 2023
@raphamorim
Copy link
Owner

Hey there @hedonistrh , thanks for the issue. I will take a look on it but I heard about this issue before so I do believe is a valid bug, marking it with bug label.

@ralgozino
Copy link
Contributor

I can confirm the same behaviour with fzf and ⌃ Control + R, but what I've noticed is that if instead of just waiting a few seconds you press a key (like the spacebar) the "popup" appears right away...

My system:

  • zsh
  • oh-my-zsh
  • powerlevel10k
  • macos

@raphamorim
Copy link
Owner

My guess is fzf is happening and Rio isn't doing a "callback rendering", which means that @ralgozino mentioned, once you press any key it will render right away.

@raphamorim
Copy link
Owner

I am rewritting the tty core now, but will give a try and see if comes with a fix for it.

@pshirshov
Copy link

Same problem here. Everything apart from fzf works well

@raphamorim
Copy link
Owner

Fixed in the main (d07feb0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants