Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Using a wrong value for a parameter in the config resets all options #168

Closed
ralgozino opened this issue Aug 2, 2023 · 2 comments
Closed
Labels
wishlist Features wishlist
Milestone

Comments

@ralgozino
Copy link
Contributor

Disclaimer: I don't know if this is a bug or not, but I think that the UX could be improved.

If I put a wrong value in a parameter in the config, for example, a wrong mode for the navigation, the other options are ignored.

In the following screenshot you can see that the font is set to Fira Code but it is ignored because the navigation mode is wrong:
image

Also opening a new window doesn't use the window-height and window-width specified in the config.

Fixing the navigation mode, the config parameters start working again:
image

So, I assume that when a value is not what Rio expects it just ignores the configuration file. I don't think that is the behaviour I'd expect as a user.

In an ideal world, I think I would like some error telling me that that value is wrong and probably Rio using the other remaining values.

@raphamorim
Copy link
Owner

In an ideal world, I think I would like some error telling me that that value is wrong and probably Rio using the other remaining values.

Yes, I agree with that. The only reason Rio doesn't make it yet is because doesn't have a hint/message UI component in the terminal.

@raphamorim
Copy link
Owner

Implementation of error UI in main, at now the configuration errors aren't more silent.

Screenshot 2023-09-08 at 17 57 52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Features wishlist
Projects
None yet
Development

No branches or pull requests

2 participants