Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 #33

Closed
thiamsantos opened this issue Feb 1, 2017 · 4 comments
Closed

ES6 #33

thiamsantos opened this issue Feb 1, 2017 · 4 comments

Comments

@thiamsantos
Copy link
Contributor

Would be cool to refactor the code to ES6, and provide the module through:

// ES6 Modules
import waterfall from 'waterfall.js'

// CommonJS Modules
const waterfall = require('waterfall.js')

And a UMD version through unpkg.

Maybe also take that opportunity to refactor and implement the tests #3.

What do you think about that?

@raphamorim
Copy link
Owner

Today, the code already works to ES6 imports and UMD

@raphamorim
Copy link
Owner

@raphamorim
Copy link
Owner

A good approach is improve ES6 import, to change import waterfall from 'waterfall'

@thiamsantos
Copy link
Contributor Author

Today, the code already works to ES6 imports and UMD

I was thinking in rewrite the lib using ES6 syntax and the import/export statement, and use a module bundler like rollup to compile to a commonjs version and a UMD version. And expose the three.

A good approach is improve ES6 import, to change import waterfall from 'waterfall'

The problem is that there is already a package under the name waterfall. And the current name seems to be a bit trick waterfall.js looks like I am importing a file not a module. The npm also recommends to not use js in the name of the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants