Upgrade bitflags dependency from 0.9 to 1.0 #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should raise the semver of pulldown_cmark itself, since the parser options got a break change. |
|
Yes, this is a breaking change. I've been thinking of batching all the pending breaking changes together, to minimize churn for clients, but I don't have a lot of time to work on this now. |
|
Any news on that ? |
raphlinus
approved these changes
Nov 2, 2018
|
I'll do a point release. This will be slightly annoying but not hugely so. Thanks, and thanks for your patience! |
Merged
raphlinus
added a commit
that referenced
this pull request
Nov 6, 2018
Update gen-tests feature after #139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #137