Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not parse hard line breaks when doing link label blocks #754

Merged

Conversation

notriddle
Copy link
Collaborator

@notriddle notriddle commented Oct 29, 2023

Fixes #753

Consider this markdown:

[x\

]: https://rust-lang.org

That's not a link definition, but pulldown-cmark thought it was. The hard line break on line 1 is an inline element, and should not prevent the paragraph break from parsing.

Consider this markdown:

```markdown
[x\

]: https://rust-lang.org
```

That's not a link definition, but pulldown-cmark thought it was.
The hard line break on line 1 is an inline element, and should not
prevent the paragraph break from parsing.
@Martin1887
Copy link
Collaborator

Thanks!

@Martin1887 Martin1887 merged commit 83f2f8c into pulldown-cmark:master Oct 31, 2023
1 check passed
@notriddle notriddle deleted the notriddle/line-break-linkdef branch October 31, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fuzz result] backslash escapes in link def prevent paragraph breaks
2 participants