Avoid updating linkdef when title isn't followed by NL #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quoted text '[foo]' should either be treated as a paragraph, or as a title attribute. The reference implementation thinks it's just text, not a title. But pulldown-cmark treated it as both, generating `<p>'<a href="https://example.com" title="[foo]">foo</a>'bar</p>`, which is definitely wrong.
The problem here is that `scan_refdef` didn't scan the
line break, except after quoted titles. This commit
makes it behave consistently, relying on the caller to
do that.
Events from pulldown-cmark:
```rust
"+ [^]:[\n'\n'\n\\\n" -> [
Start(List(None))
Start(Item)
End(Item)
End(List(false))
Start(Paragraph)
Text(Borrowed("\\"))
End(Paragraph)
]
```
Events from pandoc:
```rust
"+ [^]:[\n'\n'\n\\\n" -> [
Start(List(None))
Start(Item)
Text(Boxed("\\"))
End(Item)
End(List(false))
]
```
Events from commonmark.js:
```rust
"+ [^]:[\n'\n'\n\\\n" -> [
Start(List(None))
Start(Item)
Text(Boxed("\\"))
End(Item)
End(List(false))
]
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quoted text '[foo]' should either be treated as a paragraph, or as a title attribute. The reference implementation thinks it's just text, not a title. But pulldown-cmark treated it as both, generating
<p>'<a href="https://example.com" title="[foo]">foo</a>'bar</p>, which is definitely wrong.Fixes #791