feat(escape): separate attribute and text HTML #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notriddle
force-pushed
the
notriddle/escape-quot
branch
2 times, most recently
from
aab8d31
to
0bd0f91
Compare
This adds a function to escape attribute text, which will escape both single and double quotes, and another function used only for text nodes that doesn't. Co-authored-by: Martín Pozo <mpozo@protonmail.com>
notriddle
force-pushed
the
notriddle/escape-quot
branch
from
0bd0f91
to
836206c
Compare
|
This is better than #823, thanks! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a function to escape attribute text, which will escape both single and double quotes, and another function used only for text nodes that doesn't.
This is an alternative to #823
Fixes #598