Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 245 #248

Merged
merged 2 commits into from Jan 6, 2017
Merged

Issue 245 #248

merged 2 commits into from Jan 6, 2017

Conversation

orange-buffalo
Copy link
Contributor

Introduced Lombok, replaced equals and hashCode method with @EqualsAndHashCode annotation.
Did not apply refactoring for cases where:

Removed toString() methods but the places where tests expect specific implementation.

Btw, I have notices that class ObjectPropertyAssertion is duplicated in several modules. Maybe it makes sense to create a separate module with common test code (including this class) and use this module as a test dependency in all other places?

@coveralls
Copy link

coveralls commented Jan 6, 2017

Coverage Status

Coverage decreased (-0.8%) to 92.47% when pulling 580a30e on orange-buffalo:issue-245 into 9a2e50f on raphw:master.

@raphw
Copy link
Owner

raphw commented Jan 6, 2017

Awesome, thank you. I will try to review this sometime next week. Quite a lot of code changes but I trust its good for! Excited to see the impact on the code size.

Cheers, Rafael

@raphw raphw self-assigned this Jan 6, 2017
@raphw raphw self-requested a review January 6, 2017 12:07
@raphw raphw added this to the 1.6.1 milestone Jan 6, 2017
@raphw raphw removed their request for review January 6, 2017 12:07
@raphw raphw merged commit 580a30e into raphw:master Jan 6, 2017
@orange-buffalo orange-buffalo deleted the issue-245 branch January 6, 2017 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants