Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish the list of the official release PGP keys #721

Closed
vlsi opened this issue Sep 10, 2019 · 8 comments
Closed

Please publish the list of the official release PGP keys #721

vlsi opened this issue Sep 10, 2019 · 8 comments
Assignees
Milestone

Comments

@vlsi
Copy link

vlsi commented Sep 10, 2019

The idea is project page should provide clear steps to verify if the release is official.
I'm afraid I've no standard way of doing that, however it would be nice if you could mention the official PGP key ids in the Download section at https://bytebuddy.net

See also spring-projects/spring-framework#23434 (comment)

See also https://gitlab.ow2.org/asm/asm/issues/317884

Sample implementation for Apache JMeter: https://jmeter.apache.org/download_jmeter.cgi As you see, it refers KEYS file and links to the page with gpg commands to verify the signatures.

PS. I don't really expect that everybody would start verifying their downloads, however making the official key ID publicly available would help for automated verifications as well.

@raphw raphw self-assigned this Sep 14, 2019
@raphw raphw added this to the 1.10.0 milestone Sep 14, 2019
@raphw
Copy link
Owner

raphw commented Sep 14, 2019

Absolutely, I will add a link.

@raphw
Copy link
Owner

raphw commented Oct 24, 2019

Sorry for not following up. I'd add a reference to: https://keys.gnupg.net/pks/lookup?op=get&search=0xBB2914C1FA0811C3

You think a link like this in the readme and webpage suffices?

@vlsi
Copy link
Author

vlsi commented Oct 24, 2019

The link above produces NET::ERR_CERT_AUTHORITY_INVALID error (the certificate is not signed by a trusted root CA)

@raphw
Copy link
Owner

raphw commented Oct 24, 2019

I thought it was my VPN's fault but GNPGP seems to use an invalid certificat. A bit lame to offer an HTTP reference. Is http://pgpkeys.mit.edu/ a good hosting server? Or do you think I should add the public certificat to GitHub?

@vlsi
Copy link
Author

vlsi commented Oct 24, 2019

Do you think you can serve KEYS file from https://bytebuddy.net/ ?
That would be the least surprising.

A link from the project page to a file (raw contents rather than HTML frame) hosted by GitHub would also work.

On top of that, it would provide a transparent way to list multiple signing keys (e.g. if you want to rotate the keys and/or if you want to add a co-maintainer)

@wiktor-k
Copy link

wiktor-k commented Nov 6, 2019

Unfortunately SKS keyservers such as keys.gnupg.org and mit.edu have been having a bad time recently. I'd suggest https://keys.openpgp.org/ that's very fast and verifying (it'll check if you have access to your e-mail account). It doesn't serve unverified keys though.

Hosting it on https://bytebuddy.net/ is also a good idea as it's secure and one canonical place. (if you had an @bytebuddy.net e-mail address Web Key Directory would also be a good option.)

If I may add one more thing it would be good to rotate the key as DSA 1024 are "considered unsecure for a while now". (I'd recommend RSA 4096).

Have a nice evening! 👋

@raphw
Copy link
Owner

raphw commented Nov 7, 2019

Thanks, I rotated my key and will sign all future released with it:

https://keys.openpgp.org/search?q=B4AC8CDC141AF0AE468D16921DA784CCB5C46DD5

Starting then, I will also publish the key on the webpage and on GitHub.

@raphw
Copy link
Owner

raphw commented Nov 8, 2019

I added links to the keys on both the webpage and on GitHub and signed the latest version with a stronger certificate.

@raphw raphw closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants