meterpreter-python: Inconsistent use of tabs and spaces in indentation

[jojonas]

As the title indicates, execution of the meterpreter stage fails (tried with Python 3.6.2 on x64 Windows 10).

Traceback (most recent call last):
  File "exploit.py", line 16, in <module>
    exec(d,{'s':s})
  File "<string>", line 645
    try:

I could confirm that in the repository, there is a change in indentation mode between line 644 and 645 of meterpreter.py.

[jojonas]

The culprit seems to be this commit: b5372d2

[busterb]

Thanks, will take a look.

[busterb]

@zeroSteiner would you object to us switching python meterpreter to use all spaces as per standard python? In this case my editor always wants to put spaces in python code, which I failed to notice.

[busterb]

@bwatters-r7 could you please verify that the payload test automation catches the negative case here? Might have to try a newer python with stricter warnings.

[zeroSteiner]

@busterb no, I would not be opposed to that. It's probably better to change it sooner before there are additional extensions and the existing code grows.

[busterb]

Done, thanks!