Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a global timeout parameter to Connection #269

Closed
gschneider-r7 opened this issue Apr 13, 2017 · 1 comment
Closed

Add a global timeout parameter to Connection #269

gschneider-r7 opened this issue Apr 13, 2017 · 1 comment
Labels

Comments

@gschneider-r7
Copy link
Contributor

It should be possible to set a global timeout used by all requests when setting up the Connection object. Currently only a few specific methods support a non-default timeout value as input. For everything else the only other option is to monkey patch the APIRequest and AJAX classes to override their HTTP module setup (example). The monkey patching method is not ideal because it is extra code to copy/paste into new scripts or applications, and also because it can break when upgrading the gem. For example when we added the trusted certificate feature, anyone using the monkey patch would get non-sensical errors until they updated their monkey patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants