Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please provide a source tarball including external dependencies #59

Closed
sandrotosi opened this issue Jan 31, 2024 · 4 comments
Closed

please provide a source tarball including external dependencies #59

sandrotosi opened this issue Jan 31, 2024 · 4 comments

Comments

@sandrotosi
Copy link

Hello,
i maintain Levenshtein in Debian and while working to package 0.24.0, i noticed that you're using the extern directory with a git submodule to another project. that setup is also replicated in the source tarball release via github when you tag a release (the PyPI tarballs for 0.23.0, since 0.24.0 is currently not uploaded to that system, seems to be empty so i'm basing my work on github tarballs).

This creates an issue in Debian, since we cannot download anything from internet while building a package, so im asking if you could release a new artifact that includes the source code both for Levenshtein and any external dependency (they can live in extern, is that's where the build system expects them to be).

thanks for considering!

@maxbachmann
Copy link
Member

he PyPI tarballs for 0.23.0, since 0.24.0 is currently not uploaded to that system, seems to be empty so i'm basing my work on github tarballs

I assume you mean the sdist on pypi. That one should contain the files. I assume you are still using the old https://pypi.org/project/python-Levenshtein/ which is basically just an installer for this project. You would have to use https://pypi.org/project/Levenshtein/0.24.0/#files instead.

so im asking if you could release a new artifact that includes the source code both for Levenshtein and any external dependency (they can live in extern, is that's where the build system expects them to be).

Not sure how to do this automatically of the top of my head, but if the other options are really not enough I would look into it.

The library is already packaged for multiple systems. Usually it's based either on:

  • sdist on pypi
  • github with everything packaged separately. E.g. fedora has the following packages:
    • rapidfuzz-cpp
    • taskflow
    • python3-rapidfuzz
    • python-Levenshtein

@maxbachmann
Copy link
Member

maxbachmann commented Jan 31, 2024

You would need to package at least rapidfuzz for debian as well since it's used internally. I know someone wanted to do this in the past, but back then Cython 3 was not available for debian which was an issue. I assume it should probably be available now though.

@maxbachmann
Copy link
Member

maxbachmann commented Feb 17, 2024

ping @sandrotosi whats the state of this and is there anything I can help with? I have been contacted by others relying on the package in Debian about it being dropped soon because the current version doesn't work on Python3.12

@juliangilbey adding you here as well, since you started working on bringing rapidfuzz to debian, which is a pre-requirement here as well.

Let me know if there is anything I can do to help.

@maxbachmann
Copy link
Member

I think now that rapidfuzz and taskflow are packaged separately for debian this is no longer an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants