Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-standard function signature for get_requires_for_build_wheel() #303

Closed
troycurtisjr opened this issue Dec 20, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@troycurtisjr
Copy link

The function signature for get_requires_for_build_wheel() in _custom_build/backend.py has "self" as the first parameter, however PEP 517 lists it only with config_settings. The setuptools.build_meta.get_requires_for_build_wheel original implementation that this function "overrides" is actually a bound method, and thus doesn't take the self parameter.

It seems like that function is being used somewhere, since it seems to be getting updates, but I haven't tracked it down exactly where that is.

@maxbachmann
Copy link
Member

It appears you are correct. I opened a PR in setuptools to fix the corresponding documentation and will fix this in my build backend.

@maxbachmann
Copy link
Member

I fixed this in 8eadc37. @troycurtisjr do you need a new release with this fix?

@troycurtisjr
Copy link
Author

A new release would be great, but I can just apply a patch for now until a new release naturally happens.

@maxbachmann
Copy link
Member

I created a new release with the fix. It will be available once the CI is finished (usually takes 2-3 hours)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants