Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Reduce duplication between C++ and C APIs #134

Open
cjnolet opened this issue May 17, 2024 · 0 comments
Open

[FEA] Reduce duplication between C++ and C APIs #134

cjnolet opened this issue May 17, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@cjnolet
Copy link
Member

cjnolet commented May 17, 2024

We have several C headers that are redefining enums and structs from the corresponding C++ files. This is quickly going to become a maintenance burden, and even worse it leaves us at risk of making updates to the C++ API constructs that don't propagate to the C constructs.

As an example, I consolitated the DistanceType enum into distance.h and simply import it into the C++ namespace in distance.hpp. We should do the same across all public APIs.

@cjnolet cjnolet added the feature request New feature or request label May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: No status
Development

No branches or pull requests

1 participant