Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] consistent serialization API #143

Closed
tfeher opened this issue May 22, 2024 · 0 comments · Fixed by #148
Closed

[FEA] consistent serialization API #143

tfeher opened this issue May 22, 2024 · 0 comments · Fixed by #148
Labels
feature request New feature or request

Comments

@tfeher
Copy link
Contributor

tfeher commented May 22, 2024

  • IVF-Flat has serialize and serialize_file , where the first one serializes into a string.
  • IVF-PQ has only serialize, which serializes into file
  • CAGRA has serialize and serialize_file methods, similar to IVF-Flat

To ensure consistency, IVF-PQ should also have serialize_file (and corresponding deserialize_file) method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept host_mdspan for IVF-PQ build and extend tfeher/cuvs
1 participant
@tfeher