Potentially switch httptester backend to new db backend #328
Conversation
|
Seems reasonable to me. |
- change httptester to use DB backend - remove httptester's old backend - update httptester doc - add notes to 0.13.0 release notes
|
I added a poorly named |
|
Does the Message Tester really need the flexibility of specifying different backend names in the URL? I was thinking it'd be simpler to configure and use if it just made its own instance of the DB backend when needed, and we took the backend name out of the URLs and didn't require adding a backend to the config for message tester. |
ghost
assigned
|
Yeah, I agree. It doesn't necessarily need different backend names. The router would still need to know about the backend via What do you mean by "made it's own instance of the DB backend"? |
|
I meant instead of requiring the user to add a magic backend to INSTALLED_BACKENDS just for httptester, that httptester could call add_backend itself if it sees that its backend hasn't already been added. I guess the backend would still need to be in INSTALLED_APPS so Django would know to create its database tables, so it might not simplify the configuration all that much... |
- Use the backend name as the `name` in all the BackendMessages associated with the message tester, so we can view just those and easily clear them. - Don't pass backend names in URLs and methods - just use a fixed backend name for HTTP tester, 'message_tester'
|
@copelco I made changes to use the .name field to identify which messages came from message tester, and not passing around backend names anymore. |
... on the assumption that #328 is going in.
|
Ready to review again @copelco , I'm not going to pursue automatically creating the backend like I was thinking. |
|
I think we can remove |
@copelco ready to review again
…pi' into feature/328-httptester-use-db-backend Conflicts: docs/releases/0.13.0.rst rapidsms/backends/db/__init__.py
This is because of a Django app name collision with the database router.
| @@ -31,17 +39,21 @@ To define and use Message Tester for your RapidSMS project, you will need to: | |||
| ... | |||
| ) | |||
|
|
|||
| 3. Add the Message Tester backend to :setting:`INSTALLED_BACKENDS`:: | |||
| 3. Add the DB backend to :setting:`INSTALLED_BACKENDS` with the name | |||
There was a problem hiding this comment.
Just to be consistent across the docs, probably best to use the full DatabaseBackend name here.
|
After the doc fix, I think we're good 🌵 |
…ackend Potentially switch httptester backend to new db backend
I've created a simple DB backend. Is it worth moving httptester over to it for 0.13?
https://github.com/rapidsms/rapidsms/tree/feature/bulk-messaging-api/rapidsms/backends/db