Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #454

Merged
merged 21 commits into from Jun 13, 2015
Merged

Python 3 support #454

merged 21 commits into from Jun 13, 2015

Conversation

vkurup
Copy link
Member

@vkurup vkurup commented Jan 19, 2015

Mostly minor fixes to provide Python 3 support. This is built on top of #453.

Will probably also need doc updates, but wanted to get this out there for review in the meantime.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) when pulling 08749bc on feature/python-3-support into 7e9c49e on develop.

@dpoirier
Copy link
Member

Github seems to be showing a whole lot more commits in this pull than I think were intended to be part of it?

@vkurup
Copy link
Member Author

vkurup commented Jan 20, 2015

Yes, this is built on top of #453. Only the last commit is for Python3 support.

@mlavin
Copy link

mlavin commented Mar 17, 2015

This is awesome. The setup.py should probably also be updated with Python 3 related classifiers: https://github.com/rapidsms/rapidsms/blob/develop/setup.py#L49. Is 2.6 still supported?

@vkurup
Copy link
Member Author

vkurup commented Mar 17, 2015

Thanks, Mark! Python 2.6 is still supported, but only with Django 1.6, since that's what's included in the Django compatibility page: https://docs.djangoproject.com/en/1.7/faq/install/#what-python-version-can-i-use-with-django

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) to 84.86% when pulling 7a273cc on feature/python-3-support into 7e9c49e on develop.

@lsgunth
Copy link

lsgunth commented Apr 10, 2015

I've got a new server with Django 1.8 and python 3.2 running this code. It's so far working well (with the couple pull requests I've issued). Please release it as soon as you can.

Thanks,

Logan

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) to 84.86% when pulling 68dcdd7 on feature/python-3-support into 7e9c49e on develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.76%) to 84.86% when pulling da4a584 on feature/python-3-support into 7e9c49e on develop.

@vkurup
Copy link
Member Author

vkurup commented May 25, 2015

Any other comments on this PR? If not, I'll plan to merge in about a week or so, since I know it's gotten a decent bit of review already, and seems to be working. Thanks!

@coveralls
Copy link

Coverage Status

Coverage increased (+0.72%) to 84.82% when pulling 14ea9c0 on feature/python-3-support into 7e9c49e on develop.

@thedrow
Copy link

thedrow commented Jun 8, 2015

@vkurup If you don't mind please release a new version after merging this.
We're upgrading to Python 3 soon and we'd love to keep RapidSMS in our infrastructure.

@vkurup
Copy link
Member Author

vkurup commented Jun 13, 2015

Sorry for the delay on this. I'll work on getting a release out.

vkurup added a commit that referenced this pull request Jun 13, 2015
@vkurup vkurup merged commit 1248d73 into develop Jun 13, 2015
@tobiasmcnulty tobiasmcnulty deleted the feature/python-3-support branch March 16, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants