Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll Bars are too Scrolly #78

Closed
daryllabar opened this issue Oct 31, 2018 · 7 comments
Closed

Scroll Bars are too Scrolly #78

daryllabar opened this issue Oct 31, 2018 · 7 comments

Comments

@daryllabar
Copy link

https://www.screencast.com/t/unddiQfAv

When clicking in the text box, it scrolls to the top...

@rappen
Copy link
Owner

rappen commented Oct 31, 2018

Simple explanation: When the content is changed (selecting a new row) the cursor position is set to 0;0. When the textbox gets focus, the control makes sure the cursor position is visible.

Solution 1: Make sure textbox is always scrolled to top when selecting new row. Downside: trying to compare content "far down" of different log records gets hard.
Solution 2: Try to place cursor at top;left position in currently visible text based on current scroll-state. Downside: how to implement?

@daryllabar
Copy link
Author

It makes it even worse when you scroll with the mouse wheel, and then click, because if you scroll to the bottom, it doesn't register focus and then you click to highlight something, and it throws you up to the top...

@daryllabar
Copy link
Author

If you can get the scroll bar height, and the number of newlines, you can calculate a percentage...

@rappen
Copy link
Owner

rappen commented Oct 31, 2018

Pull Requests welcome!! 😁

@daryllabar
Copy link
Author

Raise the Bar episode 9?

@rappen
Copy link
Owner

rappen commented Nov 3, 2018

Hit it! 💪

@rappen rappen closed this as completed in 5c843a2 Dec 5, 2019
@rappen
Copy link
Owner

rappen commented Dec 5, 2019

I guess this never made it to Raise the Bar... 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants