Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test compressed files over http #111

Closed
tmylk opened this issue Mar 17, 2017 · 2 comments
Closed

Test compressed files over http #111

tmylk opened this issue Mar 17, 2017 · 2 comments
Labels
bug good first issue

Comments

@tmylk
Copy link
Contributor

tmylk commented Mar 17, 2017 •
edited

Add tests for smart_open("http://127.0.0.1/index.gz") because some changes in the PR #107 that introduced it were reverted in #110 and this new functionality might be no longer available. So needs to be re-implemented.

CC @robottwo
@mpenkov
Copy link
Collaborator

mpenkov commented Apr 22, 2018

@menshikh-iv I think this got resolved as #185 - we now have HTTP integration tests that read gzip.

https://github.com/RaRe-Technologies/smart_open/blob/master/integration-tests/test_http.py#L37

@menshikh-iv
Copy link
Contributor

@mpenkov great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mpenkov @tmylk @menshikh-iv