Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

Refactor Code #12

Closed
RARM opened this issue Jul 29, 2023 · 2 comments · Fixed by #13
Closed

Refactor Code #12

RARM opened this issue Jul 29, 2023 · 2 comments · Fixed by #13
Assignees

Comments

@RARM
Copy link
Owner

RARM commented Jul 29, 2023

Client

Ensure the client doesn't have redundant code. Some HTML files have repeating CSS code rather than using a global CSS for common styles (like fonts and background color).

Some HTML files have internal CSS, while others have external CSS files. Many HTML pages have a CSS specific for that page (e.g., library.css, home.css). Although some pages could have custom CSS, we must make the project more maintainable. Let's keep reusable styles in a global CSS and page-specific styles internally (recommendation).

Server

Remove unused Django apps.

@RARM
Copy link
Owner Author

RARM commented Jul 29, 2023

I have done some refactoring in the code base. I removed some unused server code and modified the .gitignore file to avoid tracking installed games.

I am merging the branch, but I am not closing it. @OneWorldHD, we can use this same branch to refactor client HTML and CSS.

@RARM RARM linked a pull request Jul 29, 2023 that will close this issue
@RARM RARM closed this as completed in #13 Jul 29, 2023
@RARM RARM reopened this Jul 31, 2023
@RARM
Copy link
Owner Author

RARM commented Aug 5, 2023

It seems this was completed directly in the main branch. I am closing this issue again.

@RARM RARM closed this as completed Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: 🔖 Ready
Development

Successfully merging a pull request may close this issue.

2 participants