Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing typing_extensions module and dependency updates #419

Merged
merged 3 commits into from Mar 18, 2021
Merged

Missing typing_extensions module and dependency updates #419

merged 3 commits into from Mar 18, 2021

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Mar 18, 2021 •
edited

Proposed changes:

Status (please check what you already did):

  • made PR ready for code review
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx requested a review from wochinge March 18, 2021 10:20
@alwx alwx marked this pull request as ready for review March 18, 2021 10:20
wochinge
wochinge approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Rasa Open Source repository this is only a dev dependency. Should probably also be updated there then, right?

@alwx
Copy link
Contributor Author

alwx commented Mar 18, 2021

@wochinge apparently, it's used in Rasa only for mypy (which is a dev-dependency) while here in Rasa SDK it's used right here: https://github.com/RasaHQ/rasa-sdk/blob/main/rasa_sdk/types.py
it means it shouldn't be a dev-dependency

@alwx alwx merged commit 4ba9b8e into main Mar 18, 2021
@alwx alwx deleted the dep-updates branch March 18, 2021 19:58
@wochinge
Copy link
Contributor

Cool, thanks for the explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'typing_extensions'
2 participants
@alwx @wochinge