Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingress' annotationsRasaX not getting applied #124

Closed
b-quachtran opened this issue Jan 13, 2021 · 3 comments
Closed

Ingress' annotationsRasaX not getting applied #124

b-quachtran opened this issue Jan 13, 2021 · 3 comments
Labels
type:bug 🐛 Something isn't working

Comments

@b-quachtran
Copy link

b-quachtran commented Jan 13, 2021

When running helm template, the annotations specified under annotationsRasaX in Ingress: don't get applied.

Ingress Annotation:

ingress:
  # enabled should be `true` if you want to use this ingress.
  # Note that if `nginx.enabled` is `true` the `rasa/nginx` image is used as reverse proxy.
  # In order to use nginx ingress you have to set `nginx.enabled=false`.
  enabled: true
  # annotations for the ingress - annotations are applied for the rasa and rasax ingresses
  annotations: {}
    # kubernetes.io/ingress.class: nginx
    # kubernetes.io/tls-acme: "true"
  # annotationsRasa is extra annotations for the rasa nginx ingress
  annotationsRasa: {}
  # annotationsRasaX is extra annotations for the rasa x nginx ingress
  annotationsRasaX:
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
    nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"

helm template output:

# Source: rasa-x/templates/ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: RELEASE-NAME-rasa-x
  labels:
    helm.sh/chart: rasa-x-1.7.12
    app.kubernetes.io/name: rasa-x
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "0.33.0"
    app.kubernetes.io/managed-by: Helm

When these annotations get moved to annotations: in Ingress:, however, they do work:

# ingress settings
ingress:
  # enabled should be `true` if you want to use this ingress.
  # Note that if `nginx.enabled` is `true` the `rasa/nginx` image is used as reverse proxy.
  # In order to use nginx ingress you have to set `nginx.enabled=false`.
  enabled: true
  # annotations for the ingress - annotations are applied for the rasa and rasax ingresses
  annotations:
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
    nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
    # kubernetes.io/ingress.class: nginx
    # kubernetes.io/tls-acme: "true"
  # annotationsRasa is extra annotations for the rasa nginx ingress
  annotationsRasa: {}
  # annotationsRasaX is extra annotations for the rasa x nginx ingress
  annotationsRasaX: {}

helm template output:

# Source: rasa-x/templates/ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: RELEASE-NAME-rasa-x
  labels:
    helm.sh/chart: rasa-x-1.7.12
    app.kubernetes.io/name: rasa-x
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "0.33.0"
    app.kubernetes.io/managed-by: Helm
  annotations:
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
    nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
@b-quachtran b-quachtran added the type:bug 🐛 Something isn't working label Jan 13, 2021
@b-quachtran
Copy link
Author

@tczekajlo Not sure why this is happening, since it looks like the annotations are defined here: https://github.com/RasaHQ/rasa-x-helm/blob/master/charts/rasa-x/templates/rasa-x-ingress.yaml#L18

@tczekajlo
Copy link
Contributor

tczekajlo commented Jan 13, 2021

@b-quachtran everything looks ok. The rasa-x/templates/ingress.yaml is used only if the Nginx image is used, all configuration for Nginx is included in the image.

For the nginx-ingress configuration are used two other templates, the rasa-open-source-ingress.yaml and rasa-x-ingress.yaml

  # Note that if `nginx.enabled` is `true` the `rasa/nginx` image is used as reverse proxy.
  # In order to use nginx ingress you have to set `nginx.enabled=false`.
$ helm template --set nginx.enabled=false rasa-x/rasa-x

# Source: rasa-x/templates/rasa-x-ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  name: RELEASE-NAME-rasa-x
  labels:
    helm.sh/chart: rasa-x-1.7.12
    app.kubernetes.io/name: rasa-x
    app.kubernetes.io/instance: RELEASE-NAME
    app.kubernetes.io/version: "0.33.0"
    app.kubernetes.io/managed-by: Helm
  annotations:
    nginx.ingress.kubernetes.io/proxy-body-size: "0"
    nginx.ingress.kubernetes.io/proxy-read-timeout: "3600"
    nginx.ingress.kubernetes.io/proxy-send-timeout: "3600"
[...]

@b-quachtran
Copy link
Author

Ah, that makes sense! Thanks for taking a look and for the info 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants