Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLALchemy Version constraints #10374

Closed
2 tasks done
souvikg10 opened this issue Nov 24, 2021 · 1 comment
Closed
2 tasks done

SQLALchemy Version constraints #10374

souvikg10 opened this issue Nov 24, 2021 · 1 comment
Assignees
@tayfun
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:dependencies Pull requests that update a dependency file

Comments

@souvikg10
Copy link
Contributor

souvikg10 commented Nov 24, 2021 •
edited by tayfun

Rasa Open Source version

3.0.0

Rasa SDK version

No response

Rasa X version

No response

Python version

3.8

What operating system are you using?

Linux

What happened?

It seems that the version constraint on SQLAlchemy on pyproject is between >=1.3.3, <1.5.0 ,
However with a version 1.3.24, i received the following error

ImportError: cannot import name 'URL' from 'sqlalchemy.engine'

Resolved upon upgrading to SQLAlchemy 1.4.27, thus the version constraint should >=1.4.0, <1.5.0

I am not sure what regression it might cause however on the tracker store.

Command / Request

No response

Relevant log output

ImportError: cannot import name 'URL' from 'sqlalchemy.engine'

Definition of done

  • Adjust version constraints for SQLAlchemy
  • Check that SQLAlchemy version range works with Rasa X
@souvikg10 souvikg10 added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Nov 24, 2021
@souvikg10 souvikg10 changed the title SQLALchemy Version contrainst SQLALchemy Version constraints Nov 24, 2021
@sara-tagger
Copy link
Collaborator

Thanks for raising this issue, @samsucik will get back to you about it soon✨

Please also check out the docs and the forum in case your issue was raised there too 🤗

@TyDunn TyDunn added type:dependencies Pull requests that update a dependency file priority:normal and removed priority:normal labels Nov 26, 2021
@TyDunn TyDunn added the effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Dec 3, 2021
tayfun pushed a commit that referenced this issue Dec 6, 2021
Update SQLAlchemy version in pyproject
beead1d 
Fixes #10374
@tayfun tayfun mentioned this issue Dec 6, 2021
Merged
4 tasks
tayfun pushed a commit that referenced this issue Dec 7, 2021
Update SQLAlchemy version in pyproject (#10476)
d1584bd 
Fixes #10374
@tayfun tayfun closed this as completed in dd8c6be Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tayfun tayfun

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. type:dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tayfun @souvikg10 @TyDunn @sara-tagger