Bugfix splitting of multiline messages containing buttons #11131
+44
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…x-message-with-buttons-split
…b.com/mrkaaa/rasa-bugfix into bugfix/fix-message-with-buttons-split
|
Not sure whether I need to change anything in documentation. |
|
@ancalita could you please have a look? |
losterloh
approved these changes
Jun 1, 2022
|
I am working with RASA 3.6.14, and I just discovered that this bugfix is no longer in the code. Is there any reason for this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Currently multiline messages don't get split into separate messages on two newlines if they contain buttons. And this seems to be a bug.
The change proposed is to split a message on separate messages on two newlines and include buttons with the last of them.
Some discussion on this problem I found here: #4895
Status (please check what you already did):
black(please check Readme for instructions)