Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ATO 25 keep only rasa x --production #11190

Merged
merged 13 commits into from
Jun 20, 2022
Merged

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Jun 13, 2022

Proposed changes:

  • Remove all code for running rasa x (localmode)
  • Keep the rasa x --production option which runs a Rasa server allowing for using Rasa X as the config endpoint.
    It is necessary to keep this option to avoid disrupting deployments depending on the config endpoint option.

Status (please check what you already did):

  • updated some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 requested a review from losterloh June 13, 2022 12:55
@indam23 indam23 marked this pull request as ready for review June 13, 2022 12:55
@indam23 indam23 requested a review from a team as a code owner June 13, 2022 12:55
tests/cli/test_rasa_x.py Outdated Show resolved Hide resolved
Copy link
Contributor

@losterloh losterloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🚀 good to go once CI is happy (there is a code quality violation still in there).

@indam23 indam23 enabled auto-merge (squash) June 14, 2022 09:04
@indam23 indam23 disabled auto-merge June 14, 2022 09:04
@indam23 indam23 enabled auto-merge (squash) June 14, 2022 09:05
@indam23 indam23 disabled auto-merge June 14, 2022 13:30
@indam23 indam23 enabled auto-merge (squash) June 17, 2022 11:36
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11190--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@indam23 indam23 merged commit b7bb546 into main Jun 20, 2022
@indam23 indam23 deleted the ATO-25-keep-only-x-production branch June 20, 2022 07:48
indam23 added a commit that referenced this pull request Jul 27, 2022
* Remove all references to Rasa X localmode

* keep only rasa x --production

Co-authored-by: Lukas Osterloh <lukas.osterloh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants