Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uvloop for sanic update #11322

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Bump uvloop for sanic update #11322

merged 4 commits into from
Jul 12, 2022

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Jul 12, 2022

Proposed changes:

  • Bump the required version of uvloop to accommodate Sanic version 21.12.1
  • Fix the error when training in Rasa X with version 2.8.30
[2022-07-08 12:26:34 +0000] [1] [ERROR] Exception occurred while handling uri: 'http://rasa-worker:5005/model/train?force=true&save_to_default_model_directory=true&callback_url=http://rasa-x:5002/api/projects/default/models/jobs/7/result?token%3Drasaxtoken&token=rasatoken'
Traceback (most recent call last):
  File "handle_request", line 83, in handle_request
    )
  File "/opt/venv/lib/python3.8/site-packages/rasa/server.py", line 238, in decorated
    result = await result
  File "/opt/venv/lib/python3.8/site-packages/rasa/server.py", line 600, in decorated_function
    request.app.add_task(wrapped())
  File "/opt/venv/lib/python3.8/site-packages/sanic/app.py", line 1609, in add_task
    return self._loop_add_task(
  File "/opt/venv/lib/python3.8/site-packages/sanic/app.py", line 1565, in _loop_add_task
    task = loop.create_task(prepped, name=name)
TypeError: create_task() takes no keyword arguments

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 requested a review from ancalita July 12, 2022 08:24
@indam23 indam23 marked this pull request as ready for review July 12, 2022 08:24
@indam23 indam23 merged commit 4dd809b into 2.8.x Jul 12, 2022
@indam23 indam23 deleted the ATO-212-fix-train-with-callback branch July 12, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants