-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade prompt-toolkit to 3.0 #11426
Upgrade prompt-toolkit to 3.0 #11426
Conversation
…ionaryconfirmmock
@losterloh This is now ready for review after a great troubleshooting round with @tmbo 🥳 |
@ancalita do you mind linking the ticket you created on the prompt-toolkit repo here so that we have a reference to it if / when we need to get back to this pr in the future? |
@tmbo I've just linked to it in the PR description. I also just noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 💯
@tmbo I just ran a sanity check with
After the last predicted action
I've tried amending |
🚀 A preview of the docs have been deployed at the following URL: https://11426--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Proposed changes:
<3.0.29
version because this version introduces breaking changes to unit testing interface (see submitted issue:create_pipe_input
breaking change in versions>=3.0.29
results inOSError: Bad file descriptor
prompt-toolkit/python-prompt-toolkit#1660)questionary
which hasprompt-toolkit
as dependency, e.g. replace sync methodquestionary.ask()
withask_async()
, otherwise this breaksrasa shell
by raisingRuntimeError: This event loop is already running
. The change was made in a few places:rasa/core/channels/console.py::_get_user_input()
rasa/cli/utils.py::payload_from_button_question()
rasa/core/training/interactive.py::_ask_questions()
rasa/core/training/interactive.py::_retry_on_error()
rasa/core/training/interactive.py::_ask_if_quit()
rasa/core/training/interactive.py::_request_export_info()
rasa/core/training/interactive.py::_get_button_choice()
Status (please check what you already did):
black
(please check Readme for instructions)