Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spacy Italian pre-trained model into Rasa Docker image #11517

Merged
merged 18 commits into from
Oct 25, 2022

Conversation

ibaylyak
Copy link
Contributor

@ibaylyak ibaylyak commented Aug 30, 2022

Proposed changes:

  • Add italian spacy model docker image

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@CLAassistant
Copy link

CLAassistant commented Aug 30, 2022

CLA assistant check
All committers have signed the CLA.

@ibaylyak ibaylyak requested a review from a team as a code owner August 30, 2022 12:42
@ibaylyak ibaylyak requested review from aerowithanl and removed request for a team August 30, 2022 12:42
@ibaylyak
Copy link
Contributor Author

@aerowithanl What should I do to fix unsuccessful checks?

Copy link
Collaborator

@sanchariGr sanchariGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibaylyak this looks good to me, can you please rebase against main.

@ibaylyak
Copy link
Contributor Author

@ibaylyak this looks good to me, can you please rebase against main.

done

@ibaylyak
Copy link
Contributor Author

ibaylyak commented Sep 8, 2022

@sanchariGr do I have to do anything else?

@sanchariGr sanchariGr requested review from rasa-jmac and removed request for aerowithanl September 21, 2022 12:55
@sanchariGr
Copy link
Collaborator

@sanchariGr do I have to do anything else?

@ibaylyak Apologies for the late reply, unfortunately the building docker image failure issue that you are facing here is expected since you donot have the required permissions. We would need a bit longer to come up with a solution for you.

@ibaylyak
Copy link
Contributor Author

@sanchariGr do I have to do anything else?

@ibaylyak Apologies for the late reply, unfortunately the building docker image failure issue that you are facing here is expected since you donot have the required permissions. We would need a bit longer to come up with a solution for you.

Ok

@rasa-jmac
Copy link
Contributor

@ibaylyak I've just merged what I hope is a fix to main - let's see if this works for you now.

@ibaylyak
Copy link
Contributor Author

@ibaylyak I've just merged what I hope is a fix to main - let's see if this works for you now.

ok, thank you.

@rasa-jmac
Copy link
Contributor

@ibaylyak We don't seem to be having very good luck with the CI checks for this PR. We're still investigating on our side and actively working on this.

@miraai
Copy link
Contributor

miraai commented Oct 25, 2022

@ibaylyak Hello, thank you for your patience on this, I kindly ask you to rebase against main once more and lets see if we have more luck this time :)

@ibaylyak ibaylyak reopened this Oct 25, 2022
@ibaylyak
Copy link
Contributor Author

@miraai Hello, I had a conflict in .github/workflows/continous-integration.yml

@miraai miraai added the security-review:done Security review for community PRs coming from a fork label Oct 25, 2022
@ibaylyak ibaylyak requested a review from miraai October 25, 2022 15:33
@rasa-jmac rasa-jmac merged commit 7246a15 into RasaHQ:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security-review:done Security review for community PRs coming from a fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants