-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Rasa Action Server docs in Rasa Open Source repo #11571
Conversation
do we actually need this? 🤔 we only show one docs version on the docs website per major anyways |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💯
To double-check (probably was discussed but I missed it in the Slack channel flurry of messages): where do the action-server API docs and rasa-sdk changelog live now?
docs/docs/action-server/actions.mdx
Outdated
### `responses` | ||
|
||
A response can be of any of the response types described in the | ||
[Rasa Open Source documentation on rich responses](https://rasa.com/docs/rasa/next/responses#rich-responses). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the links should be changed to use the "within-docs" style, e.g. [slot event](events.mdx#slot)
rather than using the fully qualified URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. links within the docs need to be updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small change needed but otherwise ready to go
🚀 A preview of the docs have been deployed at the following URL: https://11571--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Proposed changes:
3.2.x
Status (please check what you already did):
black
(please check Readme for instructions)