Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Rasa Action Server docs in Rasa Open Source repo #11571

Merged
merged 20 commits into from
Sep 29, 2022

Conversation

znat
Copy link
Contributor

@znat znat commented Sep 15, 2022

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • [X ] updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@znat znat changed the title Integrate-rasa-sdk-docs Integrate Rasa Action Server docs in Rasa Open Source repo Sep 15, 2022
@znat znat mentioned this pull request Sep 15, 2022
3 tasks
@znat znat requested review from a team and sanchariGr and removed request for a team September 19, 2022 12:33
@znat znat requested a review from a team September 22, 2022 09:58
@tmbo
Copy link
Member

tmbo commented Sep 22, 2022

do we actually need this? 🤔 we only show one docs version on the docs website per major anyways

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 💯
To double-check (probably was discussed but I missed it in the Slack channel flurry of messages): where do the action-server API docs and rasa-sdk changelog live now?

docs/docusaurus.config.js Show resolved Hide resolved
docs/docusaurus.config.js Show resolved Hide resolved
tmbo
tmbo previously approved these changes Sep 26, 2022
### `responses`

A response can be of any of the response types described in the
[Rasa Open Source documentation on rich responses](https://rasa.com/docs/rasa/next/responses#rich-responses).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the links should be changed to use the "within-docs" style, e.g. [slot event](events.mdx#slot) rather than using the fully qualified URL

Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. links within the docs need to be updated

@znat znat requested a review from tmbo September 27, 2022 14:25
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change needed but otherwise ready to go

docs/docs/action-server/actions.mdx Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11571--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@znat znat merged commit 7df2b7e into 3.2.x Sep 29, 2022
@znat znat deleted the integrate-rasa-sdk-docs branch September 29, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants