Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs m1 #11578

Merged
merged 27 commits into from
Oct 7, 2022
Merged

Docs m1 #11578

merged 27 commits into from
Oct 7, 2022

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Sep 19, 2022

Proposed changes:

  • revert changes done for docker support. currently not possible
  • added documentation for M1 limitations
  • added changelog

Fixes https://rasahq.atlassian.net/browse/ATO-325

@tmbo tmbo requested a review from a team as a code owner September 19, 2022 13:16
@tmbo tmbo requested review from aerowithanl and removed request for a team September 19, 2022 13:16
docs/docs/installation.mdx Outdated Show resolved Hide resolved
@tmbo tmbo requested review from ancalita, twerkmeister, rasa-jmac and chandrikas and removed request for ancalita and aerowithanl September 19, 2022 13:17
@tmbo
Copy link
Member Author

tmbo commented Sep 20, 2022

@znat do I need to do anything special to merge this ontop of your changes?

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few rephrasing suggestions 👍🏻

docs/docs/components.mdx Outdated Show resolved Hide resolved
docs/docs/installation.mdx Outdated Show resolved Hide resolved
docs/docs/installation.mdx Outdated Show resolved Hide resolved
docs/docs/installation.mdx Outdated Show resolved Hide resolved
docs/docs/installation.mdx Outdated Show resolved Hide resolved
docs/docs/installation.mdx Outdated Show resolved Hide resolved
@znat
Copy link
Contributor

znat commented Sep 20, 2022

@znat do I need to do anything special to merge this ontop of your changes?

Those changes should not conflict with other docs changes, thanks for pinging me 👍

tmbo and others added 2 commits September 20, 2022 15:00
Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
Co-authored-by: Anca Lita <27920906+ancalita@users.noreply.github.com>
@tmbo
Copy link
Member Author

tmbo commented Sep 20, 2022

@twerkmeister just to sanity check, any limitations that I missed?

@tmbo tmbo requested a review from a team as a code owner September 21, 2022 07:24

## M1 / M2 (Apple Silicon) Limitations

Rasa installations on Apple Silicon use [Apple Metal](https://developer.apple.com/metal/) leading to reduced training times
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make metal optional, and change this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind doing the change directly on this branch?

which the current tensorflow version 2.8 does not provide - only MacOS is
supported as an operating system running on aarch64. We expect a future
upgrade of Tensorflow to allow Apple Silicon users to run Rasa inside of Docker.
* Rasa on Apple Silicon does not support the [`ConveRTFeaturizer` component](components.mdx#convertfeaturizer) or pipelines
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also spacy isn't supported until we upgrade to 3.4.1.

@tmbo
Copy link
Member Author

tmbo commented Sep 26, 2022

I am going to wait until we've addressed the spacy issues before merging this.

@twerkmeister twerkmeister mentioned this pull request Oct 4, 2022
4 tasks
@tmbo tmbo requested a review from a team as a code owner October 5, 2022 07:45
@tmbo tmbo mentioned this pull request Oct 5, 2022
4 tasks
@tmbo tmbo enabled auto-merge (squash) October 7, 2022 10:17
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2022

🚀 A preview of the docs have been deployed at the following URL: https://11578--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@tmbo tmbo merged commit bce010b into main Oct 7, 2022
@tmbo tmbo deleted the docs-m1 branch October 7, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants