bumped spacy to 3.4 #11598
Merged
bumped spacy to 3.4 #11598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace Coveralls test coverage badge with CodeClimate badge
Update dependencies
…dockerfiles Only Push Docker Base Images for Internal Builds
…files Fix Condition to Detect Forks when Running CI
Add workflow step to install pluggy
4 tasks
|
🚀 A preview of the docs have been deployed at the following URL: https://11598--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
tmbo
approved these changes
Sep 30, 2022
pyproject.toml
Outdated
| @@ -203,7 +203,7 @@ version = "^0.4.4" | |||
| markers = "sys_platform == 'win32'" | |||
|
|
|||
| [tool.poetry.dependencies.spacy] | |||
| version = ">=3.1,<3.3" | |||
| version = ">=3.1,<3.5" | |||
There was a problem hiding this comment.
can we require min 3.4 on aarch64?
| fingerprint_data = { | ||
| "node_name": rasa.utils.common.module_path_from_class(graph_component_class), | ||
| "component_implementation": inspect.getsource(graph_component_class), | ||
| "config": config, | ||
| "inputs": inputs, | ||
| "dependency_versions": dependency_versions, |
There was a problem hiding this comment.
this will invalidate any existing cache entries right? Not an issue but should prob be mentioned in the changelog entry.
tmbo
approved these changes
Oct 5, 2022
|
will be merged as part of #11578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
">=3.1,<3.5"SpacyNLPcomponent. Does not change behavior as of now, but could have led to bugs if more parameters were added.SpacyNLPcomponent. Showing that case sensitivity can be disabled and enabled.Status (please check what you already did):
black(please check Readme for instructions)