Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs with strong prescriptive recommendation on how to handle dynamic form behaviour with custom slot mappings #11724

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Oct 31, 2022

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review October 31, 2022 14:21
Copy link
Contributor

@l2nguyen l2nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I made a suggestion on how the user can extract custom global slots in 3.x in the migration guide.

docs/docs/forms.mdx Outdated Show resolved Hide resolved
docs/docs/migration-guide.mdx Show resolved Hide resolved
Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@chandrikas
Copy link
Contributor

LGTM

@chandrikas chandrikas closed this Nov 2, 2022
@chandrikas chandrikas reopened this Nov 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2022

🚀 A preview of the docs have been deployed at the following URL: https://11724--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 3683c9e into 3.3.x Nov 2, 2022
@ancalita ancalita deleted the ATO-442-extract-slotname-method-fill-only-forms-required-slots-in-rasa-3 branch November 2, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants