Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Python 3.10 support #11773

Merged
merged 15 commits into from
Nov 28, 2022
Merged

Add Python 3.10 support #11773

merged 15 commits into from
Nov 28, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Nov 18, 2022

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review November 22, 2022 19:22
@ancalita ancalita requested review from a team as code owners November 22, 2022 19:22
@ancalita ancalita requested review from tmbo, aerowithanl and m-vdb and removed request for a team November 22, 2022 19:22
docs/docs/installation/installing-rasa-open-source.mdx Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
rasa/engine/storage/local_model_storage.py Outdated Show resolved Hide resolved
rasa/utils/plotting.py Outdated Show resolved Hide resolved
tests/examples/test_example_bots_training_data.py Outdated Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 great work, digging into the dependency updates.

do we also want to update the python version used in our docker containers or should that be separate?

@m-vdb
Copy link
Collaborator

m-vdb commented Nov 23, 2022

do we also want to update the python version used in our docker containers or should that be separate?

@tmbo I believe it's separate work. Infra will take care of that: they needed to upgrade the OS of docker images to address vulnerabilities, but the upgrade was blocked because the next ubuntu version pins 3.10. So I think it's going to be done as part of that work. (this ticket). I will double check with Infra to make sure this is done. Thanks for the nudge

@m-vdb
Copy link
Collaborator

m-vdb commented Nov 23, 2022

@ancalita one dead link in the docs tests makes the check fail, but it appears the link is momentarily dead, nothing we can do about it straight away. if you can merge the PR when you're ready, LMK and I'll merge even if the check is still red

@ancalita
Copy link
Member Author

@ancalita one dead link in the docs tests makes the check fail, but it appears the link is momentarily dead, nothing we can do about it straight away. if you can merge the PR when you're ready, LMK and I'll merge even if the check is still red

@m-vdb Yup sure, I'm now pending two things actually:

  • rasa-sdk alpha release
  • feedback from @twerkmeister on that rasa interactive width calculation function

@twerkmeister
Copy link
Contributor

@ancalita I am not sure what the width calculation refers to - can you give me some pointer at what to look at? I can't see any specific question about it

@ancalita
Copy link
Member Author

ancalita commented Nov 24, 2022

@ancalita I am not sure what the width calculation refers to - can you give me some pointer at what to look at? I can't see any specific question about it

Sure @twerkmeister Here is the calc_true_wrapping_width() code, this is the unit test, the last test case fails with AssertionError: 59 != 60 only with Python 3.10 + thread where this first started being discussed: #11773 (comment)

@ancalita ancalita requested review from m-vdb and tmbo November 25, 2022 15:33
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11773--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

@ancalita ancalita merged commit 48ce2ca into main Nov 28, 2022
@ancalita ancalita deleted the ATO-478-add-3.10-support branch November 28, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants