-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.10 support #11773
Add Python 3.10 support #11773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 great work, digging into the dependency updates.
do we also want to update the python version used in our docker containers or should that be separate?
@tmbo I believe it's separate work. Infra will take care of that: they needed to upgrade the OS of docker images to address vulnerabilities, but the upgrade was blocked because the next ubuntu version pins 3.10. So I think it's going to be done as part of that work. (this ticket). I will double check with Infra to make sure this is done. Thanks for the nudge |
@ancalita one dead link in the docs tests makes the check fail, but it appears the link is momentarily dead, nothing we can do about it straight away. if you can merge the PR when you're ready, LMK and I'll merge even if the check is still red |
@m-vdb Yup sure, I'm now pending two things actually:
|
@ancalita I am not sure what the width calculation refers to - can you give me some pointer at what to look at? I can't see any specific question about it |
Sure @twerkmeister Here is the calc_true_wrapping_width() code, this is the unit test, the last test case fails with |
🚀 A preview of the docs have been deployed at the following URL: https://11773--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐ ⭐ ⭐
Proposed changes:
pyproject.toml
and then lock filebytes
in Python 3.10tempfile
module.Status (please check what you already did):
black
(please check Readme for instructions)