Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added support for docker on arm #11775

Merged
merged 65 commits into from Apr 5, 2023
Merged

added support for docker on arm #11775

merged 65 commits into from Apr 5, 2023

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Nov 19, 2022 •
edited

Proposed changes:

  • build docker containers for arm
  • removed notes on restrictions

Fixes https://rasahq.atlassian.net/browse/CORE-1

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested a review from a team as a code owner November 19, 2022 21:50
@tmbo tmbo requested review from rasa-jmac and removed request for a team November 19, 2022 21:50
@tmbo tmbo requested a review from a team as a code owner November 20, 2022 12:06
@tmbo tmbo changed the base branch from main to core-15-tf-210-3 November 20, 2022 12:34
rasa-jmac
rasa-jmac reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@rasa-jmac rasa-jmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple of small comments

.github/workflows/continous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continous-integration.yml Outdated Show resolved Hide resolved
.github/workflows/continous-integration.yml Show resolved Hide resolved
@vcidst
Copy link
Contributor

vcidst commented Mar 31, 2023

Hey FYI, I'm using a Macbook Pro M1, 2020 running Ventura 13.1 and make build-docker-full works for me without any errors. I am also able to run the docker image and create containers with it

@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023

🚀 A preview of the docs have been deployed at the following URL: https://11775--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@d61h6k4 d61h6k4 merged commit 19bd6aa into main Apr 5, 2023
123 checks passed
@d61h6k4 d61h6k4 deleted the m1-docker-support branch April 5, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d61h6k4 d61h6k4 d61h6k4 left review comments

@radovanZRasa radovanZRasa radovanZRasa approved these changes

@twerkmeister twerkmeister Awaiting requested review from twerkmeister

@rasa-jmac rasa-jmac Awaiting requested review from rasa-jmac

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tmbo @vcidst @d61h6k4 @rasa-jmac @radovanZRasa @twerkmeister