Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unawaited method issue in Telegram channel interface #11818

Merged
merged 3 commits into from Nov 30, 2022

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Nov 29, 2022

Proposed changes:

  • Fixes RuntimeWarning: coroutine 'Bot.set_webhook' was never awaited issued when starting the rasa server, that causes Telegram bot to be unresponsive.
  • Tested manually with moodbot in Telegram and only locally by using ngrok, bot was responsive after the fix.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review November 29, 2022 15:33
@ancalita ancalita requested a review from a team as a code owner November 29, 2022 15:33
@ancalita ancalita requested review from znat and removed request for a team November 29, 2022 15:33
Copy link
Contributor

@znat znat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Minor doc related comment if you have time

docs/docs/connectors/telegram.mdx Outdated Show resolved Hide resolved
@@ -40,7 +40,8 @@ If you're running a Rasa server on `localhost`,
most external channels won't be able to find your server URL, since `localhost` is not open to the internet.

To make a port on your local machine publicly available on the internet,
you can use [ngrok](https://ngrok.com/).
you can use [ngrok](https://ngrok.com/). Alternatively, see this [list](https://github.com/anderspitman/awesome-tunneling)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is a real gem!

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://11818--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 8ec8097 into 3.3.x Nov 30, 2022
@ancalita ancalita deleted the ATO-492-telegram-bugfix branch November 30, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants