Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when customizing action_session_start via a custom action #12295

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Apr 19, 2023

Proposed changes:

  • Fixes ATO-604 and OSS-129. These two tickets share the same root cause that an instance of an output_channel is not given in the API function handling endpoint GET /conversations/{conversation_id}/tracker here.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review April 19, 2023 14:43
@ancalita ancalita requested a review from a team as a code owner April 19, 2023 14:43
@ancalita ancalita requested review from a team and vcidst and removed request for a team April 19, 2023 14:43
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does your commit say it is a tentative fix?

rasa/server.py Show resolved Hide resolved
@ancalita
Copy link
Member Author

Why does your commit say it is a tentative fix?

Ah it's because I didn't know if something will break in the CI and I had to change tactics. The commit message doesn't matter, I usually choose squash and merge for PRs.

…ing-messages-from-custom-action-session-start
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12295--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 52c4285 into 3.5.x Apr 19, 2023
@ancalita ancalita deleted the ATO-604-error-in-rasa-open-source-when-sending-messages-from-custom-action-session-start branch April 19, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants