-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RabbitMQ url parsing #12325
Merged
ancalita
merged 5 commits into
3.5.x
from
ATO-978-fix-removal-of-parsed-uri-parameters-from-the-rabbit-mq-host-uri
Apr 27, 2023
Merged
Fix RabbitMQ url parsing #12325
ancalita
merged 5 commits into
3.5.x
from
ATO-978-fix-removal-of-parsed-uri-parameters-from-the-rabbit-mq-host-uri
Apr 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Balowen
approved these changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
🚀 A preview of the docs have been deployed at the following URL: https://12325--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Kudos, SonarCloud Quality Gate passed!
|
radovanZRasa
approved these changes
Apr 27, 2023
ancalita
added a commit
that referenced
this pull request
Apr 28, 2023
* fix url parsing of path and query params, add integration test * add changelog entry, fix regression bug to allow credentials in URL * fix issue with pruning conflict when tests were run in parallel * apply review suggestion * make method private (cherry picked from commit b6268c3)
ancalita
added a commit
that referenced
this pull request
Apr 28, 2023
* fix url parsing of path and query params, add integration test * add changelog entry, fix regression bug to allow credentials in URL * fix issue with pruning conflict when tests were run in parallel * apply review suggestion * make method private (cherry picked from commit b6268c3)
ancalita
added a commit
that referenced
this pull request
Apr 28, 2023
* fix url parsing of path and query params, add integration test * add changelog entry, fix regression bug to allow credentials in URL * fix issue with pruning conflict when tests were run in parallel * apply review suggestion * make method private (cherry picked from commit b6268c3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
--dist loadgroup
andxdist_group
pytest markerStatus (please check what you already did):
black
(please check Readme for instructions)