Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RabbitMQ url parsing #12325

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Apr 24, 2023

Proposed changes:

  • Fixes ATO-978 and ATO-976
  • Adds integration tests for both cases (when credentials are passed in the endpoints url and when they're not)
  • Fixes docker prune conflict issue when the integration tests were run in parallel by applying pytest recommendation to use --dist loadgroup and xdist_group pytest marker

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review April 24, 2023 19:19
@ancalita ancalita requested a review from a team as a code owner April 24, 2023 19:19
@ancalita ancalita requested a review from Balowen April 24, 2023 19:19
Copy link

@Balowen Balowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@ancalita ancalita requested review from a team and radovanZRasa and removed request for a team April 25, 2023 09:03
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12325--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ancalita ancalita merged commit b6268c3 into 3.5.x Apr 27, 2023
115 checks passed
@ancalita ancalita deleted the ATO-978-fix-removal-of-parsed-uri-parameters-from-the-rabbit-mq-host-uri branch April 27, 2023 13:34
ancalita added a commit that referenced this pull request Apr 28, 2023
* fix url parsing of path and query params, add integration test

* add changelog entry, fix regression bug to allow credentials in URL

* fix issue with pruning conflict when tests were run in parallel

* apply review suggestion

* make method private

(cherry picked from commit b6268c3)
ancalita added a commit that referenced this pull request Apr 28, 2023
* fix url parsing of path and query params, add integration test

* add changelog entry, fix regression bug to allow credentials in URL

* fix issue with pruning conflict when tests were run in parallel

* apply review suggestion

* make method private

(cherry picked from commit b6268c3)
ancalita added a commit that referenced this pull request Apr 28, 2023
* fix url parsing of path and query params, add integration test

* add changelog entry, fix regression bug to allow credentials in URL

* fix issue with pruning conflict when tests were run in parallel

* apply review suggestion

* make method private

(cherry picked from commit b6268c3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants