Drop Python 3.7 Support #12355
Merged
Drop Python 3.7 Support #12355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasa-aadlv
approved these changes
May 4, 2023
| @@ -148,7 +148,7 @@ jobs: | |||
| if: needs.changes.outputs.backend == 'true' | |||
| run: | | |||
| sudo apt-get -y install libpq-dev | |||
| make install-full | |||
| make install-full || make install-full | |||
There was a problem hiding this comment.
Please add comments to document why we are repeating dependency install for future reference.
There was a problem hiding this comment.
I was just experimenting with the failed tests in CI, I've removed these changes from this PR
radovanZRasa
approved these changes
May 10, 2023
|
🚀 A preview of the docs have been deployed at the following URL: https://12355--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
m-vdb
reviewed
May 16, 2023
| @@ -87,7 +87,7 @@ line-length = 88 | |||
| select = [ "D", "E", "F", "W", "RUF",] | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = ">=3.7,<3.11" | |||
| python = ">=3.8,<3.11" | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)