Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update documentation for improvement in rasa sdk knowledge base actions based on improvements suggested in PR#922 in rasa-sdk #12362

Merged
merged 28 commits into from Jun 7, 2023
Merged

Update documentation for improvement in rasa sdk knowledge base actions based on improvements suggested in PR#922 in rasa-sdk #12362

merged 28 commits into from Jun 7, 2023

Conversation

Gajithra
Copy link
Contributor

@Gajithra Gajithra commented May 8, 2023

Proposed changes:

  • Updated Knowledge Base Actions doc for the improvement related to the PR OSS-668: Rasa Knowledge base actions are unable to query about a certain attribute of an object unless the user first asks to obtain a list of objects of a specific type. Link to this PR is accessible here.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Gajithra and others added 8 commits April 26, 2023 12:45
@Gajithra
modified content to include information on improvements related to qu…
d2eee43 
…erying knowledge base for an attribute of an object
@Gajithra
Merge pull request #1 from RasaHQ/main
380ad18 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #2 from rootcodelabs/OSS-668-Update-documentation-…
34bb255 
…for-improvement-in-rasa-sdk-knowledge-base-actions

Pulling updates from OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions to gaji-OSS-668-docs-update
@Gajithra
modified line 283 and 314 to rephrase the sentence better
9559a3f
@Gajithra
modified line 283 and 314 to rephrase the sentence better
e723996
@Gajithra
Merge pull request #3 from rootcodelabs/RAOC-25
cb41193 
RAOC-25: Modifying the content to contain description of the improvement
@Gajithra
Merge pull request #4 from RasaHQ/main
e8273e6 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #5 from RasaHQ/main
674e3e7 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra Gajithra changed the title Oss 668 update documentation for improvement in rasa sdk knowledge base actions Update documentation for improvement in rasa sdk knowledge base actions based on improvements suggested in PR#922 in rasa-sdk May 8, 2023
@Gajithra Gajithra mentioned this pull request May 8, 2023
Merged
5 tasks
@Gajithra
Merge pull request #6 from RasaHQ/main
de59621 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa  OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
Tawakalt
Tawakalt reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@Tawakalt Tawakalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. 💯
I left some few suggestions.

We can merge this only after the SDK PR has been merged.

docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
Tawakalt
Tawakalt reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@Tawakalt Tawakalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need a changelog of type doc

Gajithra and others added 4 commits May 15, 2023 09:44
@Gajithra
updated doc with PR suggestion
1804c66
@Gajithra
added changelog of type doc
00c9a12
@Gajithra
Merge pull request #7 from RasaHQ/main
117eadd 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions.
@Gajithra
Merge pull request #8 from rootcodelabs/OSS-668-Update-documentation-…
5e3619e 
…for-improvement-in-rasa-sdk-knowledge-base-actions-pr-updates

Pulling updates from rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions-pr-updates
@Gajithra
Copy link
Contributor Author

Noted and Thanks for your feedback @Tawakalt ! I have made the requested changes.

Tawakalt
Tawakalt reviewed May 16, 2023
View reviewed changes
changelog/12362.doc.md Outdated Show resolved Hide resolved
ancalita
ancalita reviewed May 16, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ⚡ I left some further suggestions below.

docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
changelog/12362.doc.md Outdated Show resolved Hide resolved
Gajithra and others added 8 commits May 17, 2023 10:32
@Gajithra
modified based on PR review suggestions
0e37dce
@Gajithra
modified changelog docs to mention about improvement in KBA and docs
1172b28
@Gajithra
Merge pull request #10 from RasaHQ/main
80d18d6 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #11 from rootcodelabs/OSS-668-Update-documentation…
c33ade4 
…-for-improvement-in-rasa-sdk-knowledge-base-actions

Pulling updates from OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions to OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions-pr-changes
@Gajithra
Merge pull request #12 from RasaHQ/main
dea75c8 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #13 from rootcodelabs/OSS-668-Update-documentation…
119770d 
…-for-improvement-in-rasa-sdk-knowledge-base-actions

Pulling updates from OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions to OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions-pr-updates
@Gajithra
Merge pull request #9 from rootcodelabs/OSS-668-Update-documentation-…
f8c0b36 
…for-improvement-in-rasa-sdk-knowledge-base-actions-pr-updates

Updated changelog doc to mention about improvement made in knowledge base action
@Gajithra
Merge pull request #14 from RasaHQ/main
6d711b9 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #15 from RasaHQ/main
7674fdc 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@ancalita ancalita self-requested a review June 5, 2023 08:38
@Gajithra
Merge pull request #16 from RasaHQ/main
29b883f 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #17 from RasaHQ/main
f4ef0da 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Merge pull request #18 from RasaHQ/main
d4f5c8f 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
ancalita
ancalita approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
As soon as you update your branch with latest main, we can merge this as well.

@Gajithra
Merge pull request #19 from RasaHQ/main
2129df0 
Pulling updates from RasaHQ/rasa main to rootcodelabs/rasa OSS-668-Update-documentation-for-improvement-in-rasa-sdk-knowledge-base-actions
@Gajithra
Copy link
Contributor Author

Gajithra commented Jun 7, 2023

🎉 As soon as you update your branch with latest main, we can merge this as well.

Awesome @ancalita ! We have updated the branch now

@ancalita ancalita merged commit 46e6c03 into RasaHQ:main Jun 7, 2023
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tawakalt Tawakalt Tawakalt left review comments

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gajithra @Tawakalt @ancalita