Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs; ATO-1063 Rasa Pro install doc update #12371

Merged
merged 4 commits into from Jun 19, 2023
Merged

Conversation

rgstephens
Copy link
Contributor

Proposed changes:

  • ...

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@andreaklmn andreaklmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rgstephens we are looking into packaging related questions, but until we actually rename the plus package to pro, do you mind if we don't replace plus with pro on the artifacts page? Just because it is named "Rasa Pro Artifacts" so it makes sense for me to represent the actual package names.

But I'm happy with all your suggested changes on the installation page!

@rgstephens
Copy link
Contributor Author

@andreaklmn Can you please review this?

- **Rasa Pro Services**, flexible infrastructure and APIs on top of Rasa
Open Source. Rasa Pro Services should be deployed alongside, but separately
from your production assistant.

Rasa Pro includes the Rasa Plus Python package, which is a drop-in replacement for Rasa Open Source that includes all the functionality of Rasa Open Source as well as additional features.
Rasa Plus features are built on a plugin architecture that is seamlessly integrated with Rasa Open Source.
Rasa Pro features are built on a plugin architecture that is seamlessly integrated with Rasa Open Source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this change!

@@ -29,4 +27,4 @@ For example, in the below diagram, tracing is run as a hook implementation in Ra
The hook configures the tracing backend as specified in the `endpoints.yml` and instruments model training and message handling actions.
The hook is then called within the Rasa Open Source main module, which is the entry point for the Rasa Open Source command line.

The plugin architecture enables Rasa Plus to continue enhancing the Rasa Open Source argument parser while maintaining the same runnable command name (`rasa`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can change to rasa pro here as well!

@m-vdb m-vdb force-pushed the ATO-1063-pro-install-docs branch from d358d4c to 1f831cb Compare June 19, 2023 14:18
@m-vdb m-vdb requested a review from a team as a code owner June 19, 2023 14:18
@m-vdb m-vdb changed the base branch from main to 3.6.x June 19, 2023 14:18
@m-vdb m-vdb enabled auto-merge June 19, 2023 14:18
@m-vdb m-vdb removed the request for review from a team June 19, 2023 14:20
@m-vdb
Copy link
Collaborator

m-vdb commented Jun 19, 2023

@rgstephens I added a missing changelog fragment (please include it next time 🙏🏻 ), changed the base branch to 3.6.x (add to cherry-pick commits and force push) instead of main, so that your changes are released sooner. And I've enabled auto-merge

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12371--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@m-vdb m-vdb merged commit b612c49 into 3.6.x Jun 19, 2023
106 checks passed
@m-vdb m-vdb deleted the ATO-1063-pro-install-docs branch June 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants