Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract CRV filtering and enable usage in CallbackNLG #12575

Merged
merged 10 commits into from Jul 21, 2023
Merged

Extract CRV filtering and enable usage in CallbackNLG #12575

merged 10 commits into from Jul 21, 2023

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Jun 27, 2023 •
edited

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review June 28, 2023 10:03
@ancalita ancalita requested a review from a team as a code owner June 28, 2023 10:03
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/callback.py Outdated Show resolved Hide resolved
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/callback.py Outdated Show resolved Hide resolved
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/generator.py Outdated Show resolved Hide resolved
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/generator.py Outdated Show resolved Hide resolved
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/generator.py Outdated Show resolved Hide resolved
vcidst
vcidst reviewed Jun 28, 2023
View reviewed changes
rasa/core/nlg/generator.py Outdated Show resolved Hide resolved
@ancalita ancalita requested a review from vcidst June 30, 2023 13:34
vcidst
vcidst approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12575--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita requested a review from vcidst July 21, 2023 10:55
vcidst
vcidst approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@vcidst vcidst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ancalita ancalita merged commit cc5c606 into 3.6.x Jul 21, 2023
99 checks passed
@ancalita ancalita deleted the ATO-1184-filter-cr-vs-based-on-the-condition-and-order-of-appearance-before-they-are-sent-to-the-nlg-server branch July 21, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcidst vcidst vcidst approved these changes

@radovanZRasa radovanZRasa Awaiting requested review from radovanZRasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ancalita @vcidst