allow components to add fingerprints of external data #12778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
approved these changes
Aug 30, 2023
| @@ -76,3 +83,44 @@ def test_fingerprint_changes_due_to_changed_source(monkeypatch: MonkeyPatch): | |||
| assert key1 != key2 | |||
|
|
|||
| get_source_mock.assert_called_once_with(TEDPolicy) | |||
|
|
|||
|
|
|||
| def test_fingerprint_changes_when_external_file_changes(): | |||
There was a problem hiding this comment.
OPT: can you split this into two tests: one testing that the fingerprint is stable and another to check it is changing?
|
🚀 A preview of the docs have been deployed at the following URL: https://12778--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
|
Kudos, SonarCloud Quality Gate passed!
|
twerkmeister
added a commit
that referenced
this pull request
Aug 31, 2023
* allow components to add fingerprints of external data
twerkmeister
added a commit
that referenced
this pull request
Aug 31, 2023
* allow components to add fingerprints of external data
4 tasks
twerkmeister
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
GraphComponentthat allows users to add additional fingerprint data to their component, such as external files, knowledge bases etc. that are not directly in the rasa graphStatus (please check what you already did):
black(please check Readme for instructions)