add username as a parameter for redis components on 3.4.x #12835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
tests/core/test_lock_store.py
Outdated
| @@ -384,3 +387,42 @@ async def test_redis_lock_store_with_valid_prefix(monkeypatch: MonkeyPatch): | |||
| with pytest.raises(LockError): | |||
| async with lock_store.lock("some sender"): | |||
| pass | |||
|
|
|||
|
|
|||
| def test_tracker_store_endpoint_config_loading(endpoints_path: Text): | |||
There was a problem hiding this comment.
Default fixture file does not have field username.
Create a new fixture file and use that.
There was a problem hiding this comment.
Ah, I've added the username field in the existing yaml file. I hope that also works?
tests/core/test_lock_store.py
Outdated
| ) | ||
|
|
||
|
|
||
| def test_create_lock_store_from_endpoint_config(domain: Domain, endpoints_path: Text): |
|
🚀 A preview of the docs have been deployed at the following URL: https://12835--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
radovanZRasa
approved these changes
Sep 22, 2023
vcidst
deleted the
ATO-1520-add-username-as-a-parameter-for-redis-components-34x
branch
This was referenced Sep 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
usernameto the connection parameters for RedisLockStoreStatus (please check what you already did):
black(please check Readme for instructions)